[PATCH v4] net/iavf: add devargs to enable vf auto-reset

[Zhang, Qi Z]

> -----Original Message-----
> From: Shiyang He <shiyangx.he at intel.com>
> Sent: Tuesday, September 26, 2023 7:32 PM
> To: dev at dpdk.org
> Cc: Zhou, YidingX <yidingx.zhou at intel.com>; He, ShiyangX
> <shiyangx.he at intel.com>; Wang, Liang-min <liang-min.wang at intel.com>;
> Zhang, Yuying <yuying.zhang at intel.com>; Xing, Beilei
> <beilei.xing at intel.com>; Su, Simei <simei.su at intel.com>; Wu, Wenjun1
> <wenjun1.wu at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Wu,
> Jingjing <jingjing.wu at intel.com>
> Subject: [PATCH v4] net/iavf: add devargs to enable vf auto-reset
> 
> Originally, the iavf PMD does not perform special actions when it receives a
> PF-to-VF reset event, resulting in vf being offline and unavailable.
> 
> This patch enables vf auto-reset by setting 'watchdog_period' devargs to true.
> The iavf PMD will perform an automatic reset to bring the vf back online
> when it receives a PF-to-VF event.
> 
> v2: handling reset by event handler
> v3: change reset process
> v3: rebase
> 
> Signed-off-by: Shiyang He <shiyangx.he at intel.com>
> Signed-off-by: Liang-Min Larry Wang <liang-min.wang at intel.com>
> ---
>  doc/guides/nics/intel_vf.rst           |  3 +
>  doc/guides/rel_notes/release_23_11.rst |  3 +
>  drivers/net/iavf/iavf.h                |  7 +++
>  drivers/net/iavf/iavf_ethdev.c         | 86 +++++++++++++++++++++++---
>  drivers/net/iavf/iavf_rxtx.c           | 52 ++++++++++------
>  drivers/net/iavf/iavf_vchnl.c          | 11 +++-
>  6 files changed, 135 insertions(+), 27 deletions(-)
> 
> diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst index
> d365dbc185..c0acd2a7f5 100644
> --- a/doc/guides/nics/intel_vf.rst
> +++ b/doc/guides/nics/intel_vf.rst
> @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the
> following documents:
>      Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog
> period in microseconds, or set it to 0 to disable the watchdog,
>      for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a
> 18:01.0,watchdog_period=0``.
> 
> +    Enable vf auto-reset by setting the ``devargs`` parameter like ``-a
> 18:01.0,enable_auto_reset=1`` when IAVF is backed

The argument enable_auto_reset=1 seems somewhat redundant; why not simply use auto_reset=1 instead?

Otherwise
Acked-by: Qi Zhang <qi.z.zhang at intel.com>