RES: [PATCH] net/ice: fix vlan stripping in double VLAN mode

Carlos de Souza Moraes Neto carlosmn at weg.net
Wed Apr 3 16:03:22 CEST 2024


Hi David,

I verified using testpmd and my application and worked fine.
Thank you for your help,

Sincerely
Carlos Moraes.

-----Mensagem original-----
De: David Marchand <david.marchand at redhat.com> 
Enviada em: quinta-feira, 28 de março de 2024 08:16
Para: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
Cc: dev at dpdk.org; Carlos de Souza Moraes Neto <carlosmn at weg.net>; mingjinx.ye at intel.com; stable at dpdk.org
Assunto: Re: [PATCH] net/ice: fix vlan stripping in double VLAN mode

ATENÇÃO:  Esta mensagem é de REMETENTE EXTERNO - Tenha cuidado ao abrir links e anexos.
*** NOVO *** NÃO digite sua SENHA WEG quando solicitada por E-MAIL EXTERNO


On Wed, Mar 27, 2024 at 7:44 PM Vladimir Medvedkin <vladimir.medvedkin at intel.com> wrote:
>
> The ICE hardware can operate in two modes - single vlan mode or double 
> vlan mode. Depending on the operating mode the hardware handles vlan 
> header with single vlan tag differently.
> When double vlan enabled, a packet with a single VLAN is treated as a 
> packet with outer VLAN only. Otherwise, a single VLAN in a packet is 
> treated as inner VLAN.
>
> This patch fixes the logic of how vlan stripping is programmed.
>
> Bugzilla ID: 1402

Nit: no need for an empty line here, the Bugzilla ID: tag goes with the Fixes: and Cc: block.

>
> Fixes: de5da9d16430 ("net/ice: support double VLAN")
> Cc: mingjinx.ye at intel.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>

Thanks Vladimir.
It looks to fix the issue I observed.
I'll let Carlos confirm the fix is good for him too.


--
David Marchand



More information about the dev mailing list