[PATCH v4 01/30] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy

Morten Brørup mb at smartsharesystems.com
Sat Apr 6 11:01:47 CEST 2024


> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, 5 April 2024 18.53
> 
> Rte_memcpy should not be used for the simple case of copying
> a fix size structure because it is slower and will hide problems

"it is slower"... not always true.
Perhaps: "it is not faster than memcpy".

> from code analysis tools. Coverity, fortify and other analyzers
> special case memcpy().
> 
> Gcc (and Clang) are smart enough to inline copies which
> will be faster.

"faster" -> "just as fast".

> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---

With the updated description,

For the series,
Acked-by: Morten Brørup <mb at smartsharesystems.com>



More information about the dev mailing list