[PATCH 16/16] build: enable vla warnings on Windows built code
Morten Brørup
mb at smartsharesystems.com
Thu Apr 18 08:48:39 CEST 2024
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
Minor detail, doesn't affect my Ack for the series...
Applications built for Windows with mingw and clang might use VLAs in the application itself.
Perhaps we should let them continue doing that for now.
>
> Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> ---
> config/meson.build | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/config/meson.build b/config/meson.build
> index 8c8b019..9e887f2 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -344,6 +344,10 @@ if cc.get_id() == 'intel'
> warning_flags += '-diag-disable=@0@'.format(i)
> endforeach
> endif
> +# no VLAs in code built on Windows
> +if is_windows
> + warning_flags += '-Wvla'
> +endif
> foreach arg: warning_flags
> if cc.has_argument(arg)
> add_project_arguments(arg, language: 'c')
> --
> 1.8.3.1
More information about the dev
mailing list