[PATCH] eal/linux: enhanced error handling for affinity

Stephen Hemminger stephen at networkplumber.org
Mon Apr 22 17:30:46 CEST 2024


On Mon, 22 Apr 2024 13:23:50 +0000
"Jianyue Wu (NSB)" <jianyue.wu at nokia-sbell.com> wrote:

> +		EAL_LOG(ERR, "Cannot set affinity for thread %s with cpus %s, "
> +			"ret: %d, errno: %d, error description: %s",
> +			thread_name, cpus_str,
> +			ret, errno, strerror(errno));
> +	}

That error message is way too long, and error strings should not be broken across lines.

			"Set affinity thread %s to %s failed: %s"

And it is a lot effort to deduce the cpuset and thread name here.
Probably better to just move the error message back to the caller.




More information about the dev mailing list