[dpdk-dev] [PATCH v5 4/4] app: hook in EAL usage help

[Stephen Hemminger]

This patch appears stuck in limbo.

Some comments.

On Mon,  5 Apr 2021 21:39:54 +0200
Thomas Monjalon <thomas at monjalon.net> wrote:

> diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c
> index 019eddb7bd..39d7fd8c69 100644
> --- a/app/test-compress-perf/comp_perf_options_parse.c
> +++ b/app/test-compress-perf/comp_perf_options_parse.c
> @@ -38,8 +38,8 @@ struct name_id_map {
>  	uint32_t id;
>  };
>  
> -static void
> -usage(char *progname)
> +void
> +comp_perf_usage(const char *progname)

Why does the hook now need to be a non-static function. Should be possible for the
hook to still just be:

static void
usage(const char *progname);

Fits the principle of change as little as possible.