[PATCH 3/4] ethdev: make TM shaper parameters constant

[Xu, Rosen]

Hi,

> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson at intel.com>
> Sent: Tuesday, August 6, 2024 11:24 PM
> To: dev at dpdk.org
> Cc: Richardson, Bruce <bruce.richardson at intel.com>; Nithin Dabilpuram
> <ndabilpuram at marvell.com>; Kiran Kumar K <kirankumark at marvell.com>;
> Sunil Kumar Kori <skori at marvell.com>; Satha Rao
> <skoteshwar at marvell.com>; Harman Kalra <hkalra at marvell.com>; Hemant
> Agrawal <hemant.agrawal at nxp.com>; Sachin Saxena
> <sachin.saxena at nxp.com>; Jie Hai <haijie1 at huawei.com>; Yisen Zhuang
> <yisen.zhuang at huawei.com>; Wu, Jingjing <jingjing.wu at intel.com>; Xu,
> Rosen <rosen.xu at intel.com>; Liron Himi <lironh at marvell.com>; Jiawen Wu
> <jiawenwu at trustnetic.com>; Jian Wang <jianwang at trustnetic.com>;
> Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; Thomas Monjalon
> <thomas at monjalon.net>; Ferruh Yigit <ferruh.yigit at amd.com>; Andrew
> Rybchenko <andrew.rybchenko at oktetlabs.ru>
> Subject: [PATCH 3/4] ethdev: make TM shaper parameters constant
> 
> The function to add a new shaper profile in rte_tm should not (and does
> not) modify the profile parameters passed in via struct pointer. We should
> guarantee this by marking the parameter pointer as const. This allows SW to
> create multiple profiles using the same parameter struct without having to
> reset it each time.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> ---
>  drivers/net/ipn3ke/ipn3ke_tm.c  | 4 ++--
> diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c
> b/drivers/net/ipn3ke/ipn3ke_tm.c index 20a0ed0467..eec01bb037 100644
> --- a/drivers/net/ipn3ke/ipn3ke_tm.c
> +++ b/drivers/net/ipn3ke/ipn3ke_tm.c
> @@ -722,7 +722,7 @@ ipn3ke_tm_node_capabilities_get(struct
> rte_eth_dev *dev,  }
> 
>  static int
> -ipn3ke_tm_shaper_parame_trans(struct rte_tm_shaper_params *profile,
> +ipn3ke_tm_shaper_parame_trans(const struct rte_tm_shaper_params
> +*profile,
>  	struct ipn3ke_tm_shaper_profile *local_profile,
>  	const struct ipn3ke_tm_shaper_params_range_type *ref_data)
> { @@ -747,7 +747,7 @@ ipn3ke_tm_shaper_parame_trans(struct
> rte_tm_shaper_params *profile,
> 
>  static int
>  ipn3ke_tm_shaper_profile_add(struct rte_eth_dev *dev,
> -	uint32_t shaper_profile_id, struct rte_tm_shaper_params *profile,
> +	uint32_t shaper_profile_id, const struct rte_tm_shaper_params
> +*profile,
>  	struct rte_tm_error *error)
>  {
>  	struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); diff --
>  /** @internal Traffic manager shaper profile delete */
> --
> 2.43.0

Reviewed-by: Rosen Xu <rosen.xu at intel.com>