[PATCH 3/4] [v1,3/4] zsda: add support for queue operation

[Stephen Hemminger]

On Thu,  8 Aug 2024 16:50:13 +0800
Hanxiao Li <li.hanxiao at zte.com.cn> wrote:

> +int
> +zsda_get_queue_cfg(struct zsda_pci_device *zsda_pci_dev)
> +{
> +	uint8_t i = 0;

Useless initialization, you are setting it the first loop.

> +	uint32_t index = 0;
> +	enum zsda_service_type type = ZSDA_SERVICE_INVALID;
> +	struct zsda_qp_hw *zsda_hw_qps = zsda_pci_dev->zsda_hw_qps;
> +	struct qinfo qcfg;
> +	int ret = 0;

Another useless initialization.

> +
> +	for (i = 0; i < zsda_num_used_qps; i++) {