[PATCH 1/4] test: update alarm test

Stephen Hemminger stephen at networkplumber.org
Thu Aug 8 20:52:23 CEST 2024


On Tue, 6 Aug 2024 14:45:45 +0200
David Marchand <david.marchand at redhat.com> wrote:

> On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger
> <stephen at networkplumber.org> wrote:
> >
> > This test should be using the TEST_ASSERT macros, and can be
> > run as part of the fast test suite now.
> >
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>  
> 
> [...]
> 
> > +       ret = rte_eal_alarm_cancel(test_alarm_callback, NULL);
> > +       /* return is the number of the alarm set (or 0 if none or -1 if error) */
> > +       TEST_ASSERT(ret > 0, "could not cancel an alarm: %d", ret);
> >
> >         return 0;
> >  }
> >
> > -REGISTER_TEST_COMMAND(alarm_autotest, test_alarm);
> > +REGISTER_FAST_TEST(alarm_autotest, true, true, test_alarm);  
> 
> This test was removed from the fast-tests list as it was triggering
> false failures in some CI.
> ee00af60170b ("test: remove strict timing requirements some tests")

I can see why that test failed (too short an alarm), but the whole test has lots
of other issues. Starting new series to address.



More information about the dev mailing list