[PATCH 2/5] Revert "test/alarm: disable bad time cases on Windows"
Stephen Hemminger
stephen at networkplumber.org
Fri Aug 9 16:59:30 CEST 2024
On Fri, 9 Aug 2024 10:23:24 +0300
Dmitry Kozlyuk <dmitry.kozliuk at gmail.com> wrote:
> 2024-08-08 12:46 (UTC-0700), Stephen Hemminger:
> > This reverts commit a089d320338d708f5b7126dab5fd6861c82e6347.
> >
> > Windows EAL should have been fixed rather than papering over
> > the bug.
>
> Linux and FreeBSD alarm implementations use the same approach
> that limits possible timeout range in API.
> Test cases in question check that these values are rejected.
> Windows EAL can accept any values.
That was a bug. There should not be different behavior
on different OS.
> I think the proper fix would be documenting Unix limitations
> at API level (it never worked the other way, so no real breakage),
> then adding the same checks to Windows EAL only for consistency.
No. All EAL should behave the same.
More information about the dev
mailing list