[PATCH] power: don't disable all cast qualifier warnings
Stephen Hemminger
stephen at networkplumber.org
Mon Aug 12 23:56:09 CEST 2024
Only in one place does the power library need un-constify a pointer
and this can be done by casting to uintptr_t first. Better, to have
the warning enabled across the rest of the code.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
lib/power/meson.build | 4 +---
lib/power/rte_power_pmd_mgmt.c | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/power/meson.build b/lib/power/meson.build
index b8426589b2..2f0f3d26e9 100644
--- a/lib/power/meson.build
+++ b/lib/power/meson.build
@@ -30,7 +30,5 @@ headers = files(
'rte_power_pmd_mgmt.h',
'rte_power_uncore.h',
)
-if cc.has_argument('-Wno-cast-qual')
- cflags += '-Wno-cast-qual'
-endif
+
deps += ['timer', 'ethdev']
diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
index b1c18a5f56..6dec282054 100644
--- a/lib/power/rte_power_pmd_mgmt.c
+++ b/lib/power/rte_power_pmd_mgmt.c
@@ -664,7 +664,7 @@ rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,
* ports before calling any of these API's, so we can assume that the
* callbacks can be freed. we're intentionally casting away const-ness.
*/
- rte_free((void *)queue_cfg->cb);
+ rte_free((void *)(uintptr_t)queue_cfg->cb);
free(queue_cfg);
return 0;
--
2.43.0
More information about the dev
mailing list