[PATCH v3 1/4] usertools/cpu_layout: update coding style

Burakov, Anatoly anatoly.burakov at intel.com
Wed Aug 21 10:49:09 CEST 2024


On 8/20/2024 5:59 PM, Robin Jarry wrote:
> Anatoly Burakov, Aug 20, 2024 at 17:35:
>> Update coding style:
>>
>> - make it PEP-484 compliant
>> - address all flake8, mypy etc. warnings
>> - use f-strings in place of old-style string interpolation
>> - refactor printing to make the code more readable
>> - read valid CPU ID's from "online" sysfs node
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
>> ---
>>
>> Notes:
>>     v1,v2 -> v3:
>>     - Import typing as T instead of individual types
> 
> Looks good to me. Same remark than dpdk-hugepages.py: could you format 
> it using black or ruff?
> 
> Thanks!
> 

Hi,

My IDE is already set up to auto-format with Ruff since our last 
conversation, so this is already formatted. I ran ruff format command 
just in case but it produced no changes.

-- 
Thanks,
Anatoly



More information about the dev mailing list