[PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style

Burakov, Anatoly anatoly.burakov at intel.com
Wed Aug 21 10:53:41 CEST 2024


On 8/20/2024 5:52 PM, Stephen Hemminger wrote:
> On Tue, 20 Aug 2024 16:35:16 +0100
> Anatoly Burakov <anatoly.burakov at intel.com> wrote:
> 
>> Update coding style:
>>
>> - Make the code PEP-484 compliant
>> - Add more comments, improve readability, use f-strings everywhere
>> - Use quotes consistently
>> - Address all Python static analysis (e.g. mypy, pylint) warnings
>> - Improve error handling
>> - Refactor printing and sysfs/procfs access functions
>> - Sort output by NUMA node
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> 
> Looks good, but not sure if always using single quote is really necessary.
> Many python programs seem to use either one indiscriminately.

Well, that doesn't mean it's a good example to follow :) At least it 
annoys me visually so I went ahead and fixed it since I was doing a 
rewrite anyway.

> 
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>

-- 
Thanks,
Anatoly



More information about the dev mailing list