[PATCH v5 3/4] usertools/dpdk-hugepages.py: update coding style

Robin Jarry rjarry at redhat.com
Wed Aug 21 13:43:40 CEST 2024


Anatoly Burakov, Aug 21, 2024 at 11:44:
> Update coding style:
>
> - make the code PEP-484 compliant
> - add more comments, improve readability, use f-strings everywhere
> - address all Python static analysis (e.g. mypy, pylint) warnings
> - format code with Ruff
> - improve error handling
> - refactor printing and sysfs/procfs access functions
> - sort huge page reservation status output by NUMA node
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>
> Notes:
>     v4 -> v5:
>     - Format with Ruff on default settings
>     - Replaced all instances of raw path strings with os.path.join
>     v3 -> v4:
>     - Format code with Ruff, line width 79 to avoid flake8 warnings
>       (Flake8 is by default configured with line width 79 on my system)
>     v2 -> v3:
>     - Rewrite of the script as suggested by reviewers
>     v1 -> v2:
>     - Added commit that sorted output by NUMA node
>
>  usertools/dpdk-hugepages.py | 518 +++++++++++++++++++++---------------
>  1 file changed, 310 insertions(+), 208 deletions(-)

Acked-by: Robin Jarry <rjarry at redhat.com>

Thanks!



More information about the dev mailing list