[RFC PATCH v3 1/2] dts: add port config mtu options to testpmd shell

Juraj Linkeš juraj.linkes at pantheon.tech
Thu Aug 22 11:14:28 CEST 2024


>> +    def configure_port_mtu_all(self, mtu_length: int) -> None:
>> +        """Set the MTU length on all designated ports.
>> +
>> +        Args:
>> +            mtu_length: The MTU length to be set on all ports.
>> +        """
>> +        for port in self.show_port_info_all():
>> +            self.send_command(f"port config mtu {port.id} {mtu_length}")

There's a patch in my capabilities series [0] that could be use here. 
I'll create a standalone patch from it.

[0] 
https://patches.dpdk.org/project/dpdk/patch/20240821145315.97974-8-juraj.linkes@pantheon.tech/

>> +
>> +    def close(self) -> None:
> 
> This looks like something that went wrong in the merge, this method is
> called _close on main and that is the one that
> SingleActiveIntactiveShells use to properly close.
> 
>>           """Overrides :meth:`~.interactive_shell.close`."""
>>           self.stop()
>>           self.send_command("quit", "Bye...")
>> --
>> 2.44.0
>>
> [1] https://patchwork.dpdk.org/project/dpdk/patch/20240709175341.183888-2-jspewock@iol.unh.edu/

These two are basically the same patch. Let's coordinate this and create 
one standalone patch that will be used for all three patches (I'm 
counting my capabilities patch as well here).


More information about the dev mailing list