[PATCH v1] net/e1000: do not update link status in secondary process
Bruce Richardson
bruce.richardson at intel.com
Thu Aug 22 18:02:31 CEST 2024
On Thu, Aug 22, 2024 at 04:58:59PM +0100, Bruce Richardson wrote:
> On Fri, Jul 12, 2024 at 07:30:47PM +0800, Jun Wang wrote:
> > The code to update link status is not safe in secondary process.
> > If called from secondary it will crash, example from dumpcap:
> > eth_em_link_update
> >
> > Signed-off-by: Jun Wang <junwang01 at cestc.cn>
> > ---
> > drivers/net/e1000/em_ethdev.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
>
> Given this is fixing an issue experienced in the real-world I think we
> should take this patch. As Stephen says, a better solution would be to have
> the whole function work properly in secondary, but I'd rather avoid crashes
> as a priority.
>
> Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)")
> Cc: stable at dpdk.org
>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
More information about the dev
mailing list