回复： [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail

[ShaoWei Sun]

Yes, you are correct, it should be the commit 2a7d0b872f79 that introduced the issue. Thank you for the correction. 


 
1819846787 at qq.com



 




------------------ 原始邮件 ------------------
发件人: "David Marchand"<david.marchand at redhat.com>; 
发送时间: 2024年2月1日(星期四) 晚上9:14
收件人: " ShaoWei Sun"<1819846787 at qq.com>; "ciara.power"<ciara.power at intel.com>; 
抄送: "dev"<dev at dpdk.org>; "Bruce Richardson"<bruce.richardson at intel.com>; "Chengwen Feng"<fengchengwen at huawei.com>; 
主题: Re: [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail



1819846787 at qq.com> wrote:
>
> Telemetry can only create 10 conns by default, each of which is processed
> by a thread.
>
> When a thread fails to write using socket, the thread will end directly
> without reducing the total number of conns.
>
> This will result in the machine running for a long time, and if there are
> 10 failures, the telemetry will be unavailable
>
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
>
> Signed-off-by: Shaowei Sun <1819846787 at qq.com>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> Acked-by: Ciara Power <ciara.power at intel.com>
> Acked-by: Chengwen Feng <fengchengwen at huawei.com>

Thanks for the fix.
As far as I can see, the limiting of the number of connections (which
here results in a DoS on the telemetry socket) was added in commit
2a7d0b872f79 ("telemetry: add upper limit on connections").

If you confirm this is indeed this commit that introduced the issue, I
will fix the Fixes: tag myself when applying.


-- 
David Marchand
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20240201/1a485edf/attachment.htm>