[Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs
Long Li
longli at microsoft.com
Fri Feb 2 02:21:46 CET 2024
> I think default burst size 32 can be used like below:
>
> struct rte_mbuf *mbufs[32];
>
> loop: //use do {} while(); if you prefer n = min(32, count);
> rte_pktmbuf_alloc_bulk(mbufs, n); for (i = 0; i < n; i++)
> mana_post_rx_wqe(rxq, mbufs[i]);
> count -= n;
> if (count > 0) goto loop:
>
>
> This additional loop doesn't make code very complex (I think not more than
> additional alloc() & free()) and it doesn't waste memory.
> I suggest doing a performance measurement with above change, it may increase
> performance, afterwards if you insist to go with original code, we can do it.
>
I submitted v4 with your suggestions. The code doesn't end up looking very messy. I measured the same performance with and without the patch.
Thanks,
Long
More information about the dev
mailing list