[PATCH 04/13] net/ionic: fix missing volatile type for cqe pointers

Stephen Hemminger stephen at networkplumber.org
Sat Feb 3 05:26:36 CET 2024


On Fri, 2 Feb 2024 11:32:29 -0800
Andrew Boyer <andrew.boyer at amd.com> wrote:

> From: Neel Patel <neel.patel at amd.com>
> 
> This memory may be changed by the hardware, so the volatile
> keyword is required for correctness.
> 
> Fixes: e86a6fcc7cf3 ("net/ionic: add optimized non-scattered Rx/Tx")
> cc: stable at dpdk.org
> 
> Signed-off-by: Andrew Boyer <andrew.boyer at amd.com>
> Signed-off-by: Neel Patel <neel.patel at amd.com>

In general barriers are better than volatile.
Volatile is a compiler not hardware construct really.

https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html


More information about the dev mailing list