[PATCH 4/6] ethdev: add modify action support for IPsec fields

[Dariusz Sosnowski]

Hi Slava,

> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo at nvidia.com>
> Sent: Tuesday, February 6, 2024 13:18
> To: dev at dpdk.org
> Cc: Matan Azrad <matan at nvidia.com>; Raslan Darawsheh
> <rasland at nvidia.com>; Ori Kam <orika at nvidia.com>; Dariusz Sosnowski
> <dsosnowski at nvidia.com>
> Subject: [PATCH 4/6] ethdev: add modify action support for IPsec fields
> 
> The following IPsec related field definitions added:
> 
>  - RTE_FLOW_FIELD_ESP_SPI - SPI value in IPsec header
>  - RTE_FLOW_FIELD_ESP_SEQ_NUM - sequence number in header
>  - RTE_FLOW_FIELD_ESP_PROTO - next protocol value in trailer
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> ---
>  doc/guides/rel_notes/release_24_03.rst | 4 ++++
>  lib/ethdev/rte_flow.h                  | 5 ++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/release_24_03.rst
> b/doc/guides/rel_notes/release_24_03.rst
> index 3e33ff2d86..2f78009dd8 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -65,6 +65,10 @@ New Features
>    * Added ``RTE_FLOW_ITEM_TYPE_RANDOM`` to match random value.
>    * Added ``RTE_FLOW_FIELD_RANDOM`` to represent it in field ID struct.
>    * Added ``RTE_FLOW_FIELD_IPV4_PROTO`` to represent it in field ID struct.
> +  * Added ``RTE_FLOW_FIELD_ESP_SPI`` to represent it in field ID struct.
> +  * Added ``RTE_FLOW_FIELD_ESP_SEQ_NUM`` to represent it in field ID struct.
> +	* Added ``RTE_FLOW_FIELD_ESP_PROTO`` to represent it in field ID struct.
Could you please align this line with the rest of the items in that list, so that release notes generate properly?

Other than that, looks good to me.

Best regards,
Dariusz Sosnowski