[PATCH v4] common/sfc: replace out of bounds condition with static_assert

Ferruh Yigit ferruh.yigit at amd.com
Mon Feb 12 13:09:35 CET 2024


On 2/12/2024 5:48 AM, Stephen Hemminger wrote:
> The sfc base code had its own definition of static assertions
> using the out of bound array access hack. Replace it with a
> static_assert like rte_common.h.
> 
> The use of null pointer to compute offset is not always a constant
> in older versions of clang. Use standard offsetof() instead.
> 
> Fixes: f67e4719147d ("net/sfc/base: fix coding style")> Cc: stable at dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Morten Brørup <mb at smartsharesystems.com>
> Reviewed-by: Morten Brørup <mb at smartsharesystems.com>
> 

Looks good to me,
unless there is no objection from driver maintainers I will merge it.



More information about the dev mailing list