[PATCH v2 1/3] examples/l2fwd-keepalive: don't use EAL logtype

Morten Brørup mb at smartsharesystems.com
Fri Feb 16 09:04:21 CET 2024


> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, 16 February 2024 04.36
> 
> EAL logtype should be reserved for EAL library.
> This example is already using printf() so just print
> errors to stderr.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Huisong Li <lihuisong at huawei.com>
> ---

Optionally, please consider using RTE_LOG(INFO, L2FWD, ...) instead. This would require #define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1 in the shm.c file too, or defining it in a common header for the two C files.

And while you are at it, shm.c also has a couple of printf for warnings; please consider converting those too. Either to RTE_LOG(INFO, L2FWD, ...) or to fprintf(stderr, ...).

Anyway...

Acked-by: Morten Brørup <mb at smartsharesystems.com>



More information about the dev mailing list