[PATCH v2 2/3] net/ionic: remove duplicate barriers
Andrew Boyer
andrew.boyer at amd.com
Tue Feb 20 21:42:25 CET 2024
These barriers are duplicated by the barriers inside
rte_write64(). Remove them to improve performance.
Signed-off-by: Neel Patel <neel.patel at amd.com>
Signed-off-by: Andrew Boyer <andrew.boyer at amd.com>
---
drivers/net/ionic/ionic_main.c | 1 -
drivers/net/ionic/ionic_rxtx_sg.c | 1 -
drivers/net/ionic/ionic_rxtx_simple.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c
index 1f24f64a33..814bb3b8f4 100644
--- a/drivers/net/ionic/ionic_main.c
+++ b/drivers/net/ionic/ionic_main.c
@@ -223,7 +223,6 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)
q->head_idx = Q_NEXT_TO_POST(q, 1);
/* Ring doorbell */
- rte_wmb();
ionic_q_flush(q);
err_out:
diff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c
index e8dec99c04..3820fd850f 100644
--- a/drivers/net/ionic/ionic_rxtx_sg.c
+++ b/drivers/net/ionic/ionic_rxtx_sg.c
@@ -218,7 +218,6 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts,
}
if (nb_tx > 0) {
- rte_wmb();
ionic_txq_flush(q);
txq->last_wdog_cycles = rte_get_timer_cycles();
diff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c
index 9674b4d1df..4c9b9415ad 100644
--- a/drivers/net/ionic/ionic_rxtx_simple.c
+++ b/drivers/net/ionic/ionic_rxtx_simple.c
@@ -191,7 +191,6 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
}
if (nb_tx > 0) {
- rte_wmb();
ionic_txq_flush(q);
txq->last_wdog_cycles = rte_get_timer_cycles();
--
2.17.1
More information about the dev
mailing list