[EXT] Re: [PATCH v2] raw/cnxk_bphy: switch to dynamic logging
Tomasz Duszynski
tduszynski at marvell.com
Wed Feb 21 09:43:49 CET 2024
>-----Original Message-----
>From: Thomas Monjalon <thomas at monjalon.net>
>Sent: Wednesday, February 21, 2024 3:00 AM
>To: Tomasz Duszynski <tduszynski at marvell.com>
>Cc: dev at dpdk.org; Jakub Palider <jpalider at marvell.com>; Jerin Jacob <jerinj at marvell.com>;
>david.marchand at redhat.com; stephen at networkplumber.org; Jerin Jacob <jerinjacobk at gmail.com>
>Subject: [EXT] Re: [PATCH v2] raw/cnxk_bphy: switch to dynamic logging
>
>External Email
>
>----------------------------------------------------------------------
>06/12/2023 15:09, Jerin Jacob:
>> On Mon, Nov 27, 2023 at 11:42 PM Tomasz Duszynski
>> <tduszynski at marvell.com> wrote:
>> >
>> > Dynamically allocated log type is a standard approach among all drivers.
>> > Switch to it.
>> >
>> > Signed-off-by: Tomasz Duszynski <tduszynski at marvell.com>
>> > ---
>> > v2:
>> > - cleanup remaining plt_ log calls
>>
>> Applied to dpdk-next-net-mrvl/for-main. Thanks
>
>Sorry, a patch from Stephen has been merged first in the main tree.
>
>The main difference is on log registration:
>Stephen's patch:
> RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_bphy, bphy, INFO); Tomasz' patch:
> RTE_LOG_REGISTER_DEFAULT(bphy_rawdev_logtype, WARNING);
> RTE_LOG_REGISTER_DEFAULT(bphy_cgx_rawdev_logtype, INFO);
>
>There are also many leftovers that were missed in Stephen's patch (plt_err, plt_warn).
>
>Please could you send a rebased patch to fix what was merged?
>
Okay, I'll clean it up.
More information about the dev
mailing list