[PATCH v3 1/7] ethdev: support report register names and filter
Jie Hai
haijie1 at huawei.com
Mon Feb 26 03:41:15 CET 2024
On 2024/2/20 23:13, Stephen Hemminger wrote:
> On Tue, 20 Feb 2024 18:58:17 +0800
> Jie Hai <haijie1 at huawei.com> wrote:
>
>> This patch adds "filter" and "names" fields to "rte_dev_reg_info"
>> structure. Names of registers in data fields can be reported and
>> the registers can be filtered by their names.
>>
>> The new API rte_eth_dev_get_reg_info_ext() is added to support
>> reporting names and filtering by names. And the original API
>> rte_eth_dev_get_reg_info() does not use the name and filter fields.
>> A local variable is used in rte_eth_dev_get_reg_info for
>> compatibility. If the drivers does not report the names, set them
>> to "offset_XXX".
>>
>> Signed-off-by: Jie Hai <haijie1 at huawei.com>
>> ---
>> doc/guides/rel_notes/release_24_03.rst | 9 +++++++
>> lib/ethdev/rte_dev_info.h | 11 ++++++++
>> lib/ethdev/rte_ethdev.c | 36 ++++++++++++++++++++++++++
>> lib/ethdev/rte_ethdev.h | 28 ++++++++++++++++++++
>> lib/ethdev/version.map | 1 +
>> 5 files changed, 85 insertions(+)
>
> Could you add support to DPDK ethtool for displaying these?
> .
Hi, Stephen,
Thanks for your review.
The app proc-info and ethtool already support dump registers with
the rte_eth_dev_get_reg_info API. For the use of the new API,
I think it's better to discuss whether to add or replace the
API of the two apps after the API of the new version is applied.
Best Regards,
Jie Hai
More information about the dev
mailing list