[EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

[Amit Prakash Shukla]

Hi Chengwen,

I liked your suggestion and tried making changes, but encountered parsing issue for CFG files with line greater than CFG_VALUE_LEN=256(current value set).

There is a discussion on the similar lines in another patch set: https://patchwork.dpdk.org/project/dpdk/patch/20231206112952.1588-1-vipin.varghese@amd.com/.

I believe this patch can be taken as-is and we can come up with the solution when we can increase the CFG_VALUE_LEN as changing CFG_VALUE_LEN in this release is causing ABI breakage.

Thanks,
Amit Shukla

> -----Original Message-----
> From: Amit Prakash Shukla
> Sent: Wednesday, February 28, 2024 3:08 PM
> To: fengchengwen <fengchengwen at huawei.com>; Cheng Jiang
> <honest.jiang at foxmail.com>; Gowrishankar Muthukrishnan
> <gmuthukrishn at marvell.com>
> Cc: dev at dpdk.org; Jerin Jacob <jerinj at marvell.com>; Anoob Joseph
> <anoobj at marvell.com>; Kevin Laatz <kevin.laatz at intel.com>; Bruce
> Richardson <bruce.richardson at intel.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula at marvell.com>
> Subject: RE: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional
> transfer
> 
> Hi Chengwen,
> 
> Please see my reply in-line.
> 
> Thanks
> Amit Shukla
> 
> > -----Original Message-----
> > From: fengchengwen <fengchengwen at huawei.com>
> > Sent: Wednesday, February 28, 2024 12:34 PM
> > To: Amit Prakash Shukla <amitprakashs at marvell.com>; Cheng Jiang
> > <honest.jiang at foxmail.com>; Gowrishankar Muthukrishnan
> > <gmuthukrishn at marvell.com>
> > Cc: dev at dpdk.org; Jerin Jacob <jerinj at marvell.com>; Anoob Joseph
> > <anoobj at marvell.com>; Kevin Laatz <kevin.laatz at intel.com>; Bruce
> > Richardson <bruce.richardson at intel.com>; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula at marvell.com>
> > Subject: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional
> > transfer
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > Hi Amit and Gowrishankar,
> >
> > It's nature to support multiple dmadev test in one testcase, and the
> > original framework supports it.
> > But it seem we both complicated it when adding support for non-
> mem2mem
> > dma test.
> >
> > The new added "direction" and "vchan_dev" could treat as the dmadev's
> > private configure, some thing like:
> >
> >
> lcore_dma=lcore10 at 0000:00:04.2,vchan=0,dir=mem2dev,devtype=pcie,radd
> > r=xxx,coreid=1,pfid=2,vfid=3
> >
> > then this bi-directional could impl only with config:
> >
> >
> lcore_dma=lcore10 at 0000:00:04.2,dir=mem2dev,devtype=pcie,raddr=xxx,cor
> > eid=1,pfid=2,vfid=3,
> >
> lcore11 at 0000:00:04.3,dir=dev2mem,devtype=pcie,raddr=xxx,coreid=1,pfid=
> > 2,vfid=3
> > so that the lcore10 will do mem2dev with device 0000:00:04.2, while
> > lcore11 will do dev2mem with device 0000:00:04.3.
> 
> Thanks for the suggestion. I will make the suggested changes and send the
> next version.