[PATCH v2 3/8] rawdev: fix calloc parameters

[fengchengwen]

Reviewed-by: Chengwen Feng <fengchengwen at huawei.com>

Thanks

On 2024/1/25 2:54, Ferruh Yigit wrote:
> gcc [1] generates warning [2] about calloc usage, because calloc
> parameter order is wrong, fixing it by replacing parameters.
> 
> [1]
> gcc (GCC) 14.0.0 20240108 (experimental)
> 
> [2]
> Compiling C object .../lib/librte_rawdev.a.p/rawdev_rte_rawdev.c.o
> ../lib/rawdev/rte_rawdev.c: In function ‘handle_dev_dump’:
> ../lib/rawdev/rte_rawdev.c:659:29:
>   error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier
>   argument and not in the later argument
>   [-Werror=calloc-transposed-args]
>   659 |     buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
>       |                         ^~~~
> 
> Fixes: e915d404eb72 ("rawdev: support telemetry dump rawdev")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at amd.com>
> ---
> Cc: fengchengwen at huawei.com
> ---
>  lib/rawdev/rte_rawdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c
> index 474bdc95407f..4f8897b63947 100644
> --- a/lib/rawdev/rte_rawdev.c
> +++ b/lib/rawdev/rte_rawdev.c
> @@ -656,7 +656,7 @@ handle_dev_dump(const char *cmd __rte_unused,
>  	if (!rte_rawdev_pmd_is_valid_dev(dev_id))
>  		return -EINVAL;
>  
> -	buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
> +	buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char));
>  	if (buf == NULL)
>  		return -ENOMEM;
>  
>