[PATCH 1/2] build: fix reasons conflict

Tyler Retzlaff roretzla at linux.microsoft.com
Wed Jan 31 21:36:52 CET 2024


On Wed, Jan 31, 2024 at 06:02:49PM +0000, Bruce Richardson wrote:
> On Wed, Jan 31, 2024 at 06:45:51PM +0100, David Marchand wrote:
> > The "_disable_reason" variables are subject to naming conflicts.
> > 
> > This has been caught while looking at mingw builds where the graph
> > application was skipped with an <unknown_reason> (which is caused by a
> > missing reason variable set in app/graph/meson.build) and the graph
> > library was skipped with the same <unknown_reason> too, even though
> > this library meson does set a proper reason variable.
> > 
> > Example in GHA:
> > 
> > =================
> > Content Skipped
> > =================
> > 
> > apps:
> > 	dumpcap:	not supported on Windows
> > 	graph:	<unknown reason>
> > 	pdump:	not supported on Windows
> > ...
> > 
> > libs:
> > 	acl:	not supported on Windows
> > 	bbdev:	not supported on Windows
> > ...
> > 	graph:	<unknown reason>
> > 	node:	not supported on Windows
> > 
> > Prefix all those variables with the type of component.
> > 
> > Fixes: ecf75180171b ("build: list selected applications")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: David Marchand <david.marchand at redhat.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>

Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>


More information about the dev mailing list