[PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

Morten Brørup mb at smartsharesystems.com
Mon Jun 3 07:24:43 CEST 2024


> IMHO the only sane thing is:
>   -if keep crc is enabled then pkt_len and data_len include the extra
> bytes for the CRC.

Agree.
Consider a segmented packet where only the CRC is in the last segment.
The length of that last segment would be zero if the CRC length was not included in pkt_len and data_len.
Or, if the last two bytes of the CRC is in the last segment; the length of that last segment would be -2 if not including the CRC length.

>   -if keep crc is disabled, then pkt_len and data_len match the length
> of the packet without the CRC.



More information about the dev mailing list