[PATCH v2 2/8] dts: use Params for interactive shells

[Juraj Linkeš]

On 9. 5. 2024 13:20, Luca Vizzarro wrote:
> Make it so that interactive shells accept an implementation of `Params`
> for app arguments. Convert EalParameters to use `Params` instead.
> 
> String command line parameters can still be supplied by using the
> `Params.from_str()` method.
> 
> Signed-off-by: Luca Vizzarro <luca.vizzarro at arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek at arm.com>

Reviewed-by: Juraj Linkeš <juraj.linkes at pantheon.tech>

> diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py
> index 97aa26d419..c886590979 100644
> --- a/dts/framework/testbed_model/sut_node.py
> +++ b/dts/framework/testbed_model/sut_node.py

> @@ -393,24 +376,21 @@ def create_eal_parameters(
>           if prefix:
>               self._dpdk_prefix_list.append(prefix)
>   
> -        if vdevs is None:
> -            vdevs = []
> -
>           if ports is None:
>               ports = self.ports
>   
> -        return EalParameters(
> +        return EalParams(
>               lcore_list=lcore_list,
>               memory_channels=self.config.memory_channels,
>               prefix=prefix,
>               no_pci=no_pci,
>               vdevs=vdevs,
>               ports=ports,
> -            other_eal_param=other_eal_param,
> +            other_eal_param=Params.from_str(other_eal_param),

So this is where from_str() is used. I guess it didn't get removed in a 
subsequent patche where the last usage of it was removed.