[PATCH] telemetry: lower log level on socket error

[Christian Ehrhardt]

On Thu, Jun 6, 2024 at 2:27 PM David Marchand <david.marchand at redhat.com> wrote:
>
> When starting two DPDK programs using the same DPDK prefix (like for
> example OVS and testpmd, both running as primary processes in
> --in-memory mode), the first DPDK process of the two spews some error
> log when the second starts:
>
> TELEMETRY: Socket write base info to client failed
>
> This is because telemetry init involves trying to connect on existing
> sockets to check if it can take over an existing socket file.
>
> On the other hand, this error log provides no helpful information.
> Lower this log to debug level.

I agree, it is useful info in rare occasions, but not a "please
consider having a panic" error level.
Thank you for polishing all edges of this one issue that I raised originally!

Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>

> Fixes: e14bb5f10509 ("telemetry: fix connected clients count")
> Cc: stable at dpdk.org
>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
>  lib/telemetry/telemetry.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
> index 1663bd8c68..509fae76ec 100644
> --- a/lib/telemetry/telemetry.c
> +++ b/lib/telemetry/telemetry.c
> @@ -382,7 +382,7 @@ client_handler(void *sock_id)
>                         "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}",
>                         telemetry_version, getpid(), MAX_OUTPUT_LEN);
>         if (write(s, info_str, strlen(info_str)) < 0) {
> -               TMTY_LOG_LINE(ERR, "Socket write base info to client failed");
> +               TMTY_LOG_LINE(DEBUG, "Socket write base info to client failed");
>                 goto exit;
>         }
>
> --
> 2.44.0
>


-- 
Christian Ehrhardt
Director of Engineering, Ubuntu Server
Canonical Ltd