Coding Style for local variables
Konstantin Ananyev
konstantin.ananyev at huawei.com
Mon Jun 10 18:31:55 CEST 2024
> The coding style guide says:
>
> "Variables should be declared at the start of a block of code rather than in the middle. The exception to this is when the variable is
> const in which case the declaration must be at the point of first use/assignment. Declaring variable inside a for loop is OK."
>
> Since DPDK switched to C11, variables can be declared where they are used, which reduces the risk of using effectively uninitialized
> variables. "Effectively uninitialized" means initialized to 0 or NULL where declared, to silence any compiler warnings about the use of
> uninitialized variables.
>
> Can we please agree to remove the recommendation/requirement to declare variables at the start of a block of code?
I know that modern C standards allow to define variable in the middle.
But I am strongly opposed to allow that in DPDK coding style.
Such practice makes code much harder to read and understand (at least for me).
Konstantin
More information about the dev
mailing list