[PATCH 03/10] vdpa/nfp: fix the logic of reconfiguration

Maxime Coquelin maxime.coquelin at redhat.com
Thu Jun 13 13:43:23 CEST 2024



On 4/26/24 09:48, Chaoyong He wrote:
> From: Xinying Yu <xinying.yu at corigine.com>
> 
> The ctrl words of vDPA is locate on the extend word, so should
> use the 'nfp_ext_reconfig()' rather than 'nfp_reconfig()'.

located*
extended*

so it should*

> 
> Also replace the misuse of 'NFP_NET_CFG_CTRL_SCATTER' macro
> with 'NFP_NET_CFG_CTRL_VIRTIO'.
> 
> Fixes: b47a0373903f ("vdpa/nfp: add datapath update")
> Cc: chaoyong.he at corigine.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Xinying Yu <xinying.yu at corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
> Reviewed-by: Long Wu <long.wu at corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang at corigine.com>
> ---
>   drivers/common/nfp/nfp_common_ctrl.h |  1 +
>   drivers/vdpa/nfp/nfp_vdpa_core.c     | 16 ++++++++++++----
>   2 files changed, 13 insertions(+), 4 deletions(-)
> 

With commit message fixed (I can do it if only change needed in the
series):

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks,
Maxime



More information about the dev mailing list