[PATCH v3 07/22] common/idpf: convert data type to 'le'

Burakov, Anatoly anatoly.burakov at intel.com
Fri Jun 14 14:19:01 CEST 2024


On 6/12/2024 5:52 AM, Soumyadeep Hore wrote:
> 'u32' data type is used for the struct members in
> 'virtchnl2_version_info' which should be '__le32'.
> Make the change accordingly.

It is not stated why the data type "should" be __le32. Can the commit 
message be clarified to explain why this should be the case?

> 
> Signed-off-by: Soumyadeep Hore <soumyadeep.hore at intel.com>
> ---
>   drivers/common/idpf/base/virtchnl2.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h
> index 851c6629dd..1f59730297 100644
> --- a/drivers/common/idpf/base/virtchnl2.h
> +++ b/drivers/common/idpf/base/virtchnl2.h
> @@ -471,8 +471,8 @@
>    * error regardless of version mismatch.
>    */
>   struct virtchnl2_version_info {
> -	u32 major;
> -	u32 minor;
> +	__le32 major;
> +	__le32 minor;
>   };
>   
>   VIRTCHNL2_CHECK_STRUCT_LEN(8, virtchnl2_version_info);

-- 
Thanks,
Anatoly



More information about the dev mailing list