[PATCH v2 5/5] baseband/acc: cosmetic log changes

Thomas Monjalon thomas at monjalon.net
Fri Jun 14 23:12:11 CEST 2024


14/06/2024 23:04, Thomas Monjalon:
> 02/05/2024 22:45, Hernan Vargas:
> > -			rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"\n", desc->req.word0);
> > +			rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"", desc->req.word0);
> 
> Why keeping an empty string after PRIx32? Should I remove it when pulling?
> The title should be about removing superfluous empty line?

I'm quite sure answers are "yes", so I move forward.

Also please rename log functions in all bbdev PMDs as they are defined inside the drivers.
For instance you should rename rte_bbdev_log to acc_log in this driver.
Same for rte_bbdev_log_debug.




More information about the dev mailing list