[PATCH] telemetry: lower log level on socket error

[Stephen Hemminger]

On Mon, 17 Jun 2024 15:28:17 +0100
Bruce Richardson <bruce.richardson at intel.com> wrote:

> On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote:
> > When starting two DPDK programs using the same DPDK prefix (like for
> > example OVS and testpmd, both running as primary processes in
> > --in-memory mode), the first DPDK process of the two spews some error
> > log when the second starts:
> > 
> > TELEMETRY: Socket write base info to client failed
> > 
> > This is because telemetry init involves trying to connect on existing
> > sockets to check if it can take over an existing socket file.
> > 
> > On the other hand, this error log provides no helpful information.
> > Lower this log to debug level.
> > 
> > Fixes: e14bb5f10509 ("telemetry: fix connected clients count")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: David Marchand <david.marchand at redhat.com>  
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> 
> Would it be also worthwhile having the probing process wait a small amount
> of time or check for an input string before closing the socket? That should
> avoid the error message being necessary at all for the case described.

If telemetry used abstract socket path instead this would not be a problem.
Using regular paths leads to races and problems with restart.
And all the stat and runtime check logic could go away.