[PATCH v2 057/148] net/ice/base: get rid of enum ice_status

[Bruce Richardson]

On Wed, Jun 12, 2024 at 04:00:51PM +0100, Anatoly Burakov wrote:
> From: Ian Stokes <ian.stokes at intel.com>
> 
> Replace enum ice_status with int. Also replcae ICE_SUCCESS instances with 0.
> 
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel at intel.com>
> Signed-off-by: Ian Stokes <ian.stokes at intel.com>
> ---
>  drivers/net/ice/base/ice_common.c | 12 ++--
>  drivers/net/ice/base/ice_ptp_hw.c | 93 +++++++++++++++----------------
>  drivers/net/ice/base/ice_ptp_hw.h | 20 +++----
>  drivers/net/ice/base/ice_switch.c | 20 +++----
>  4 files changed, 71 insertions(+), 74 deletions(-)
> 

This looks a duplicate of patch 1 of the series. Rather than having two
patches removing ice_status, can all instances be removed in patch 1, and
then avoid adding new ones in subsequent patches. This will also remove the
previously flagged build errors due to type mismatches of int vs enum.

One suggestion might be to rename "enum ice_status" to e.g."enum
ice_status__" as part of patch one, meaning any subsequent use of it as a
type will trigger a build error, while still allowing use of the individual
values from it. WDYT?

/Bruce