[PATCH v12 0/4] remove use of RTE_MARKER fields in libraries
David Marchand
david.marchand at redhat.com
Wed Jun 19 17:01:22 CEST 2024
As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting
descriptor fields and removing cachline fields.
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove
RTE_MARKER fields.
For cacheline{0,1} fields remove fields entirely and use inline
functions to prefetch.
Provide new rearm_data and rx_descriptor_fields1 fields in anonymous
unions as single element arrays of with types matching the original
markers to maintain API compatibility.
Note: diff is easier viewed with -b due to additional nesting from
unions / structs that have been introduced.
v12:
* rebased,
* did some cosmetic changes,
* and resending to double check CI (v11 had an issue in UNH Debian
containers),
v11:
* correct doxygen comment style for field documentation.
v10:
* move removal notices in in release notes from 24.03 to 24.07.
v9:
* provide narrowest possible libabigail.abignore to suppress
removal of fields that were agreed are not actual abi changes.
v8:
* rx_descriptor_fields1 array is now constexpr sized to
24 / sizeof(void *) so that the array encompasses fields
accessed via the array.
* add a comment to rx_descriptor_fields1 array site noting
that void * type of elements is retained for compatibility
with existing drivers.
* clean up comments of fields in rte_mbuf to be before the
field they apply to instead of after.
* duplicate alignas(RTE_CACHE_LINE_MIN_SIZE) into both legs of
conditional compile for first field of cacheline 1 instead of
once before conditional compile block.
v7:
* complete re-write of series, previous versions not noted. all
reviewed-by and acked-by tags (if any) were removed.
--
David Marchand
Tyler Retzlaff (4):
net/i40e: use mbuf prefetch helper
mbuf: remove marker fields
security: remove marker fields
cryptodev: remove marker fields
devtools/libabigail.abignore | 6 +
doc/guides/rel_notes/release_24_07.rst | 3 +
drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +-
lib/cryptodev/cryptodev_pmd.h | 3 +-
lib/mbuf/rte_mbuf.h | 4 +-
lib/mbuf/rte_mbuf_core.h | 188 ++++++++++++------------
lib/security/rte_security_driver.h | 3 +-
7 files changed, 112 insertions(+), 97 deletions(-)
--
2.45.1
More information about the dev
mailing list