rte_bitmap_free() Re: DPDK Coverity issue 426433

[Stephen Hemminger]

On Thu, 20 Jun 2024 13:45:39 +0000
"Boyer, Andrew" <Andrew.Boyer at amd.com> wrote:

> Hello John,
> While Coverity is correct that this is a useless call, that's an internal implementation detail of rte_bitmap_free() - not really something the caller should know about.
> 
> Can we annotate rte_bitmap_free() in some way to eliminate these? This is not the first PMD that's had this issue reported against it.
> 
> Thanks,
> Andrew
> 


The function should have not been declared void, no caller checks return value
and all other free() type functions are void. Not sure why function even
exists to be honest.

Also, bitmap code should really be split into inline (fast path)
and non inline (slow path).