[PATCH] app/graph: fix destination buffer too small
Mahmoud Maatuq
mahmoudmatook.mm at gmail.com
Sun Jun 23 22:09:21 CEST 2024
as sizeof(config.rx.mempool_name) is < sizeof(res->mempool), it's safer
to copy min size of them to avoide out of bound memory write.
Coverity issue: 415430
Fixes: 3850cb06ab9c ("app/graph: add ethdev commands")
Cc: skori at marvell.com
Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm at gmail.com>
---
app/graph/ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c
index cfc1b18569..4b6009ee12 100644
--- a/app/graph/ethdev.c
+++ b/app/graph/ethdev.c
@@ -671,7 +671,8 @@ cmd_ethdev_parsed(void *parsed_result, __rte_unused struct cmdline *cl, void *da
memset(&config, 0, sizeof(struct ethdev_config));
config.rx.n_queues = res->nb_rxq;
config.rx.queue_size = ETHDEV_RX_DESC_DEFAULT;
- memcpy(config.rx.mempool_name, res->mempool, strlen(res->mempool));
+ memcpy(config.rx.mempool_name, res->mempool,
+ RTE_MIN(sizeof(config.rx.mempool_name), strlen(res->mempool)));
config.tx.n_queues = res->nb_txq;
config.tx.queue_size = ETHDEV_TX_DESC_DEFAULT;
--
2.43.0
More information about the dev
mailing list