[PATCH] devtools: fix version variable not initialized
huangdengdui
huangdengdui at huawei.com
Fri Jun 28 08:55:21 CEST 2024
On 2024/6/27 22:28, David Marchand wrote:
> On Wed, Apr 17, 2024 at 11:32 AM Dengdui Huang <huangdengdui at huawei.com> wrote:
>>
>> The version variable is not initialized. Therefore, if the -V option
>> is not specified, the value of $version is obtained from the context,
>> which may cause the version map parsing failure.
>>
>> Fixes: 6edec7f202ac ("devtools: list symbols by version")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui at huawei.com>
>
> This is an internal script and I wonder how the mentionned issue is hit.
> In any case this fix is correct.
>
> Reviewed-by: David Marchand <david.marchand at redhat.com>
>
>
Thanks for your review.
The project build script may pass version information through environment variables.
This problem occurs if the following execution sequence exists:
export version=devel
meson build
ninja -C build
More information about the dev
mailing list