[PATCH v4] vhost: enhance virtqueue access lock asserts

David Marchand david.marchand at redhat.com
Tue Mar 5 10:04:23 CET 2024


On Tue, Feb 27, 2024 at 11:39 AM David Marchand
<david.marchand at redhat.com> wrote:
>
> A simple comment in vhost_user_msg_handler() is not that robust.
>
> Add a lock_all_qps property to message handlers so that their
> implementation can add a build check and assert a vq is locked.
>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> ---
> Changes since v3:
> - directly called static_assert() with improved message,
>
> Changes since v2:
> - dropped review tags,
> - following use of static_assert() in RTE_BUILD_BUG_ON, reworked build
>   check by using enums (one enum is now defined per message type),
> - as the added enums must be defined early, moved the definitions of
>   handlers at the top of the file,
>
> Changes since v1:
> - moved this patch as the last of the series,

Applied, thanks.


-- 
David Marchand



More information about the dev mailing list