[EXT] [PATCH] app/test: don't count skipped tests as executed
Akhil Goyal
gakhil at marvell.com
Tue Mar 5 15:36:27 CET 2024
> Subject: [EXT] [PATCH] app/test: don't count skipped tests as executed
> The logic around skipped tests is a little confusing in the unit test
> runner.
> * Any explicitly disabled tests are counted as skipped but not
> executed.
> * Any tests that return TEST_SKIPPED are counted as both skipped and
> executed, using the same statistics counters.
>
> This makes the stats very strange and hard to correlate, since the
> totals don't add up. One would expect that SKIPPED + EXECUTED +
> UNSUPPORTED == TOTAL, and that PASSED + FAILED == EXECUTED.
>
> To achieve this, mark any tests returning TEST_SKIPPED, or ENOTSUP as
> not having executed.
>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
Yes this makes sense.
One would say executed should count the unsupported cases as well.
But I think this makes sense to not include them in executed cases.
This would give better correlation.
Can we backport this as well?
More information about the dev
mailing list