[PATCH v3 28/33] net/ena/hal: cosmetic changes
Brandes, Shai
shaibran at amazon.com
Tue Mar 12 18:12:17 CET 2024
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at amd.com>
> Sent: Friday, March 8, 2024 7:45 PM
> To: Brandes, Shai <shaibran at amazon.com>
> Cc: dev at dpdk.org
> Subject: RE: [EXTERNAL] [PATCH v3 28/33] net/ena/hal: cosmetic changes
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On 3/8/2024 5:43 PM, Ferruh Yigit wrote:
> > On 3/6/2024 12:24 PM, shaibran at amazon.com wrote:
> >> From: Shai Brandes <shaibran at amazon.com>
> >>
> >> 1. modify log prints to use correct format specifier
> >> for unsigned variables.
> >>
> >
> > I am not user using correct format specifier is cosmetic change,
> > perhaps we don't understand same thing, can you please define "cosmetic
> change"?
> >
>
> I am not sure ...
[Brandes, Shai] since all values printed are positive, it does not really matter if we use %d or %u.
Just wanted to align the logs to use the unsigned integer and not the signed one, for consistency.
I will change the wording to better explain this
More information about the dev
mailing list