[EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption

Akhil Goyal gakhil at marvell.com
Tue Mar 19 09:23:21 CET 2024


> > > +	if (options->test == CPERF_TEST_TYPE_THROUGHPUT &&
> > > +	    (options->aead_op == RTE_CRYPTO_AEAD_OP_DECRYPT ||
> > > +	     options->cipher_op == RTE_CRYPTO_CIPHER_OP_DECRYPT) &&
> > > +			!options->out_of_place) {
> > > +		RTE_LOG(ERR, USER1, "Only out-of-place is allowed in
> > > throughput decryption.\n");
> > > +		return -EINVAL;
> > > +	}
> >
> > This check is blocking cipher_only decryption which should pass irrespective of
> > inplace/oop and Data correct/incorrect.
> 
> Sorry, in that case I will remove "options->cipher_op ==
> RTE_CRYPTO_CIPHER_OP_DECRYPT" and only kept " options->aead_op ==
> RTE_CRYPTO_AEAD_OP_DECRYPT ", what do you think?

I would suggest to check for "auth_op == RTE_CRYPTO_AUTH_OP_VERIFY"
Instead of cipher_op.

Ciara, What do you suggest? You were also seeing some issues in this patch.


More information about the dev mailing list