[PATCH] cmdline: configure input buffer size
Etelson, Gregory
getelson at nvidia.com
Wed May 1 17:56:37 CEST 2024
Hello Stephen,
>>> Basic question, what would be the impact of increasing the default from 512
>>> to 1k or 2k? Do we get a large memory footprint increase, or is it just an
>>> extra 1 or 2k of memory used?
>>>
>>> /Bruce
>>>
>>
>> Increasing the RDLINE_BUF_SIZE size will also increase application memory usage.
>> However, that memory increase was required, because application could not fit
>> it's command line into the default buffer.
>>
>> Applications that can run with the default RDLINE_BUF_SIZE are not affected by
>> that patch.
>>
>> Regards,
>> Gregory
>
>
> The buffer is transient so should have little impact.
> Why not just use LINE_MAX from limits.h?
>
The LINE_MAX value will be enough even for the template API testpmd commands.
If there will be no objections, I'll set LINE_MAX as the new
RDLINE_BUF_SIZE.
Regards,
Gregory
More information about the dev
mailing list