[PATCH] net/af_packet: fix statistics
Stephen Hemminger
stephen at networkplumber.org
Wed May 1 18:44:36 CEST 2024
On Wed, 1 May 2024 17:25:59 +0100
Ferruh Yigit <ferruh.yigit at amd.com> wrote:
> > - Remove the tx_error counter since it was not correct.
> > When transmit ring is full it is not an error and
> > the driver correctly returns only the number sent.
> >
>
> nack
> Transmit full is not only return case here.
> There are actual errors continue to process relying this error calculation.
> Also there are error cases like interface down.
> Those error cases should be handled individually if we remove this.
> I suggest split this change to separate patch.
I see multiple drivers have copy/pasted same code and consider
transmit full as an error. It is not.
There should be a new statistic at ethdev layer that does record
transmit full, and make it across all drivers, but that would have
to wait for ABI change.
More information about the dev
mailing list