[PATCH v9 1/9] net/tap: do not duplicate fd's

Stephen Hemminger stephen at networkplumber.org
Thu May 2 18:22:49 CEST 2024


On Thu, 2 May 2024 15:51:43 +0100
Ferruh Yigit <ferruh.yigit at amd.com> wrote:

> I agree on the fix, only I don't think it belongs to this patch.
> 
> As far as I can see 'rxq_fds' was already initialized to '-1' and
> original code was already wrong.
> 
> This patch merges 'rxq_fds' & 'txq_fds' to 'fds', but this patch doesn't
> do anything that requires updating the above condition, or if I missing
> it please show me.
> 
> I think better to fix condition first in a separate patch.

Your right rxq_fds was not checked correctly in original code.
Let me split out that one.


More information about the dev mailing list