[PATCH v5 22/45] raw/ifpga: use rte stdatomic API

[Xu, Rosen]

Hi,

> -----Original Message-----
> From: Tyler Retzlaff <roretzla at linux.microsoft.com>
> Sent: Tuesday, May 7, 2024 1:58 AM
> To: dev at dpdk.org
> Cc: Mattias Rönnblom <mattias.ronnblom at ericsson.com>; Morten Brørup
> <mb at smartsharesystems.com>; Sevincer, Abdullah
> <abdullah.sevincer at intel.com>; Ajit Khaparde
> <ajit.khaparde at broadcom.com>; Alok Prasad <palok at marvell.com>;
> Burakov, Anatoly <anatoly.burakov at intel.com>; Andrew Rybchenko
> <andrew.rybchenko at oktetlabs.ru>; Anoob Joseph <anoobj at marvell.com>;
> Richardson, Bruce <bruce.richardson at intel.com>; Marohn, Byron
> <byron.marohn at intel.com>; Chenbo Xia <chenbox at nvidia.com>;
> Chengwen Feng <fengchengwen at huawei.com>; Loftus, Ciara
> <ciara.loftus at intel.com>; Power, Ciara <ciara.power at intel.com>; Dariusz
> Sosnowski <dsosnowski at nvidia.com>; Hunt, David <david.hunt at intel.com>;
> Devendra Singh Rawat <dsinghrawat at marvell.com>; Carrillo, Erik G
> <erik.g.carrillo at intel.com>; Guoyang Zhou <zhouguoyang at huawei.com>;
> Harman Kalra <hkalra at marvell.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; Nagarahalli, Honnappa
> <Honnappa.Nagarahalli at arm.com>; Jakub Grajciar <jgrajcia at cisco.com>;
> Jerin Jacob <jerinj at marvell.com>; Jeroen de Borst <jeroendb at google.com>;
> Jian Wang <jianwang at trustnetic.com>; Jiawen Wu
> <jiawenwu at trustnetic.com>; Jie Hai <haijie1 at huawei.com>; Wu, Jingjing
> <jingjing.wu at intel.com>; Joshua Washington <joshwash at google.com>;
> Joyce Kong <joyce.kong at arm.com>; Guo, Junfeng
> <junfeng.guo at intel.com>; Laatz, Kevin <kevin.laatz at intel.com>; Konstantin
> Ananyev <konstantin.v.ananyev at yandex.ru>; Liang Ma
> <liangma at liangbit.com>; Long Li <longli at microsoft.com>; Maciej Czekaj
> <mczekaj at marvell.com>; Matan Azrad <matan at nvidia.com>; Maxime
> Coquelin <maxime.coquelin at redhat.com>; Chautru, Nicolas
> <nicolas.chautru at intel.com>; Ori Kam <orika at nvidia.com>; Pavan Nikhilesh
> <pbhagavatula at marvell.com>; Mccarthy, Peter
> <peter.mccarthy at intel.com>; Rahul Lakkireddy
> <rahul.lakkireddy at chelsio.com>; Pattan, Reshma
> <reshma.pattan at intel.com>; Xu, Rosen <rosen.xu at intel.com>; Ruifeng
> Wang <ruifeng.wang at arm.com>; Rushil Gupta <rushilg at google.com>;
> Gobriel, Sameh <sameh.gobriel at intel.com>; Sivaprasad Tummala
> <sivaprasad.tummala at amd.com>; Somnath Kotur
> <somnath.kotur at broadcom.com>; Stephen Hemminger
> <stephen at networkplumber.org>; Suanming Mou
> <suanmingm at nvidia.com>; Sunil Kumar Kori <skori at marvell.com>; Sunil
> Uttarwar <sunilprakashrao.uttarwar at amd.com>; Tetsuya Mukawa
> <mtetsuyah at gmail.com>; Vamsi Attunuru <vattunuru at marvell.com>;
> Viacheslav Ovsiienko <viacheslavo at nvidia.com>; Medvedkin, Vladimir
> <vladimir.medvedkin at intel.com>; Xiaoyun Wang
> <cloud.wangxiaoyun at huawei.com>; Wang, Yipeng1
> <yipeng1.wang at intel.com>; Yisen Zhuang <yisen.zhuang at huawei.com>;
> Ziyang Xuan <xuanziyang2 at huawei.com>; Tyler Retzlaff
> <roretzla at linux.microsoft.com>
> Subject: [PATCH v5 22/45] raw/ifpga: use rte stdatomic API
> 
> Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding
> rte_atomic_xxx optional rte stdatomic API.
> 
> Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  drivers/raw/ifpga/ifpga_rawdev.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/raw/ifpga/ifpga_rawdev.c
> b/drivers/raw/ifpga/ifpga_rawdev.c
> index f89bd3f..78d3c88 100644
> --- a/drivers/raw/ifpga/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga/ifpga_rawdev.c
> @@ -73,7 +73,7 @@
> 
>  static struct ifpga_rawdev ifpga_rawdevices[IFPGA_RAWDEV_NUM];
> 
> -static int ifpga_monitor_refcnt;
> +static RTE_ATOMIC(int) ifpga_monitor_refcnt;
>  static rte_thread_t ifpga_monitor_start_thread;
> 
>  static struct ifpga_rawdev *
> @@ -512,7 +512,7 @@ static int set_surprise_link_check_aer(
>  	int gsd_enable, ret;
>  #define MS 1000
> 
> -	while (__atomic_load_n(&ifpga_monitor_refcnt,
> __ATOMIC_RELAXED)) {
> +	while (rte_atomic_load_explicit(&ifpga_monitor_refcnt,
> +rte_memory_order_relaxed)) {
>  		gsd_enable = 0;
>  		for (i = 0; i < IFPGA_RAWDEV_NUM; i++) {
>  			ifpga_rdev = &ifpga_rawdevices[i];
> @@ -549,7 +549,7 @@ static int set_surprise_link_check_aer(
> 
>  	dev->poll_enabled = 1;
> 
> -	if (!__atomic_fetch_add(&ifpga_monitor_refcnt, 1,
> __ATOMIC_RELAXED)) {
> +	if (!rte_atomic_fetch_add_explicit(&ifpga_monitor_refcnt, 1,
> +rte_memory_order_relaxed)) {
>  		ret =
> rte_thread_create_internal_control(&ifpga_monitor_start_thread,
>  				"ifpga-mon", ifpga_rawdev_gsd_handle,
> NULL);
>  		if (ret != 0) {
> @@ -573,7 +573,8 @@ static int set_surprise_link_check_aer(
> 
>  	dev->poll_enabled = 0;
> 
> -	if (!(__atomic_fetch_sub(&ifpga_monitor_refcnt, 1,
> __ATOMIC_RELAXED) - 1) &&
> +	if (!(rte_atomic_fetch_sub_explicit(&ifpga_monitor_refcnt, 1,
> +	    rte_memory_order_relaxed) - 1) &&
>  		ifpga_monitor_start_thread.opaque_id != 0) {
>  		ret =
> pthread_cancel((pthread_t)ifpga_monitor_start_thread.opaque_id);
>  		if (ret)
> --
> 1.8.3.1

Reviewed-by: Rosen Xu <rosen.xu at intel.com>