[PATCH v2 07/25] net/axgbe: enable PLL control for fixed PHY modes only
Ferruh Yigit
ferruh.yigit at amd.com
Mon May 20 13:25:31 CEST 2024
On 5/7/2024 1:42 PM, Venkat Kumar Ande wrote:
> PLL control setting(RRC) is needed only in fixed PHY configuration to
> fix the peer-peer issues. Without the PLL control setting, the link up
> takes longer time in a fixed phy configuration.
>
> Without the fix the user will not get the link come UP.
>
> Driver implements SW RRC for Autoneg On configuration, hence PLL control
> setting (RRC) is not needed for AN On configuration, and can be skipped.
>
> Also, PLL re-initialization is not needed for PHY Power Off and RRC
> commands. Otherwise, they lead to mailbox errors. Added the changes
> accordingly.
>
> Fixes: 09b0a36cc7ae ("net/axgbe: toggle PLL settings during rate change")
> Cc: stable at dpdk.org
>
> Signed-off-by: Venkat Kumar Ande <venkatkumar.ande at amd.com>
>
Build fails with this patch.
'AXGBE_MB_CMD_POWER_OFF' & 'AXGBE_MB_CMD_RRC' are missing in the patch,
and they are added later in patch 17/25.
As this is only build fix related to the patch order, please keep Acks
from Selwin in next version (I mean keep ack tags embedded in next
version, so that no need to send new set of acks.)
Thanks,
ferruh
More information about the dev
mailing list